Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-deprecated Kibana SAML callback URL in smoke tests #98883

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Use non-deprecated Kibana SAML callback URL in smoke tests #98883

merged 3 commits into from
Oct 12, 2023

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Aug 25, 2023 •
edited
Loading

In https://github.com/elastic/kibana/blob/b33effa182bcb7c9620c5435ab252d8067732655/x-pack/plugins/security/server/routes/authentication/saml.ts#L27

/api/security/saml/callback is the correct URL,
while /api/security/v1/saml is the deprecated URL.

See also: elastic/kibana#81733

Fixes: #99986

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.11.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 25, 2023
@rodrigc rodrigc changed the title Use non-deprecated URL: /api/security/callback/saml Use non-deprecated URL: /api/security/saml/callback Aug 28, 2023
@nik9000 nik9000 added the :Security/Security Security issues without another label label Aug 31, 2023
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Aug 31, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@rodrigc rodrigc changed the title Use non-deprecated URL: /api/security/saml/callback Use non-deprecated URL: /api/security/saml/callback in SAML smoketests Aug 31, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@gwbrown
Copy link
Contributor

gwbrown commented Oct 12, 2023

@elasticmachine test this please

@gwbrown gwbrown self-requested a review October 12, 2023 15:42
@gwbrown gwbrown self-assigned this Oct 12, 2023
@gwbrown gwbrown added the >test Issues or PRs that are addressing/adding tests label Oct 12, 2023
@gwbrown
Copy link
Contributor

gwbrown commented Oct 12, 2023

@elasticmachine update branch

@gwbrown
Copy link
Contributor

gwbrown commented Oct 12, 2023

@elasticmachine test this please

@gwbrown
Fix summary
8b0ba0a 
Our tooling doesn't like slashes in these summary fields, so I adjusted the name of the patch slightly to avoid them.
@gwbrown
Copy link
Contributor

gwbrown commented Oct 12, 2023

@elasticmachine test this please

@gwbrown gwbrown changed the title Use non-deprecated URL: /api/security/saml/callback in SAML smoketests Use non-deprecated Kibana SAML callback URL in smoke tests Oct 12, 2023
@gwbrown gwbrown merged commit 9792e8b into elastic:main Oct 12, 2023
18 checks passed
@rodrigc rodrigc deleted the saml-fix-1 branch October 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

Assignees

@gwbrown gwbrown

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smoke-test-all-realms should use /api/security/saml/callback
6 participants
@rodrigc @elasticsearchmachine @gwbrown @mattc58 @nik9000 @elasticmachine